Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2480#discussion_r159407800
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
 ---
    @@ -144,10 +147,37 @@ public void open(Map conf, TopologyContext context, 
SpoutOutputCollector collect
             setCommitMetadata(context);
     
             tupleListener.open(conf, context);
    +        if (canRegisterMetrics()) registerMetric();
    --- End diff --
    
    Nit: Use braces.


---

Reply via email to