Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2480#discussion_r159119938 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java --- @@ -0,0 +1,118 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.storm.kafka.spout.metrics; + +import com.google.common.base.Supplier; +import org.apache.kafka.clients.consumer.KafkaConsumer; +import org.apache.kafka.common.TopicPartition; +import org.apache.storm.kafka.spout.internal.OffsetManager; +import org.apache.storm.metric.api.IMetric; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.HashMap; +import java.util.Map; +import java.util.Set; + +public class KafkaOffsetMetric implements IMetric { + + private static final Logger LOG = LoggerFactory.getLogger(KafkaOffsetMetric.class); + private final Supplier<Map<TopicPartition, OffsetManager>> offsetManagerSupplier; + private final Supplier<KafkaConsumer> consumerSupplier; + + public KafkaOffsetMetric(Supplier offsetManagerSupplier, Supplier consumerSupplier) { --- End diff -- What's the reasoning behind passing Supplier rather than the actual object?
---