Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159959648
--- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java ---
@@ -196,19 +197,21 @@ public static Executor mkExecutor(WorkerState
workerState, List<Long> executorId
executor.stats = new
BoltExecutorStats(ConfigUtils.samplingRate(executor.getStormConf()),ObjectReader.getInt(executor.getStormConf().get(Config.NUM_STAT_BUCKETS)));
}
+ int minId = Integer.MAX_VALUE;
Map<Integer, Task> idToTask = new HashMap<>();
for (Integer taskId : taskIds) {
+ minId = Math.min(minId, taskId);
try {
Task task = new Task(executor, taskId);
- executor.sendUnanchored(
- task, StormCommon.SYSTEM_STREAM_ID, new
Values("startup"), executor.getExecutorTransfer());
+ task.sendUnanchored( StormCommon.SYSTEM_STREAM_ID, new
Values("startup"), executor.getExecutorTransfer(), null); // TODO: Roshan: does
this get delivered/handled anywhere ?
--- End diff --
Answer:
storm-core/test/clj/integration/org/apache/storm/integration_test.clj
It can sometimes be helpful with debugging when you have topology.debug
enabled, but it is not that critical and can probably be removed if you want
to. If not please remove the comment.
---