Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2502#discussion_r159969170
  
    --- Diff: storm-client/src/jvm/org/apache/storm/utils/JCQueue.java ---
    @@ -0,0 +1,458 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License
    + */
    +
    +package org.apache.storm.utils;
    +
    +import org.apache.storm.policy.IWaitStrategy;
    +import org.apache.storm.metric.api.IStatefulObject;
    +import org.apache.storm.metric.internal.RateTracker;
    +import org.jctools.queues.MessagePassingQueue;
    +import org.jctools.queues.MpscArrayQueue;
    +import org.jctools.queues.MpscUnboundedArrayQueue;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.util.ArrayList;
    +import java.util.HashMap;
    +import java.util.concurrent.atomic.AtomicLong;
    +
    +
    +public final class JCQueue implements IStatefulObject {
    +    private static final Logger LOG = 
LoggerFactory.getLogger(JCQueue.class);
    +
    +    public static final Object INTERRUPT = new Object();
    +
    +    private final ThroughputMeter emptyMeter = new 
ThroughputMeter("EmptyBatch");
    --- End diff --
    
    This is never reported anywhere...  Do we want to just delete it and move 
ThroughputMeter to perf?


---

Reply via email to