Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2502#discussion_r160066094
  
    --- Diff: storm-client/src/jvm/org/apache/storm/daemon/Task.java ---
    @@ -177,6 +195,35 @@ public BuiltinMetrics getBuiltInMetrics() {
             return builtInMetrics;
         }
     
    +
    +    // Non Blocking call. If cannot emit to destination immediately, such 
tuples will be added to `pendingEmits` argument
    +    public void sendUnanchored(String stream, List<Object> values, 
ExecutorTransfer transfer, Queue<AddressedTuple> pendingEmits) {
    +        Tuple tuple = getTuple(stream, values);
    +        List<Integer> tasks = getOutgoingTasks(stream, values);
    +        for (Integer t : tasks) {
    +            AddressedTuple addressedTuple = new AddressedTuple(t, tuple);
    +            transfer.tryTransfer(addressedTuple, pendingEmits);
    +        }
    +    }
    +
    +    /**
    +     * Send sampled data to the eventlogger if the global or component 
level debug flag is set (via nimbus api).
    +     */
    +    public void sendToEventLogger(Executor executor, List values,
    --- End diff --
    
    I reread the code and found sampling percentage can be changed. I was 
thinking about reducing random.nextDouble(), but in this case we may not be 
able to do that. Please ignore my previous comment.


---

Reply via email to