Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2504#discussion_r162322132
  
    --- Diff: storm-client/src/storm.thrift ---
    @@ -836,3 +837,24 @@ exception HBAuthorizationException {
     exception HBExecutionException {
       1: required string msg;
     }
    +
    +struct WorkerMetricFields {
    --- End diff --
    
    Looks like WorkerMetricFields and WorkerMetricList, WorkerMetrics are used 
"before", forward reference.
    
    We encountered the issue because of forward reference of thrift definition. 
https://issues.apache.org/jira/browse/STORM-1842
    
    Could you rearrange the order so that all the structs are defined earlier 
before using them?


---

Reply via email to