Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2504#discussion_r162506645
--- Diff:
storm-server/src/main/java/org/apache/storm/metricstore/FilterOptions.java ---
@@ -0,0 +1,159 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.storm.metricstore;
+
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Map;
+import java.util.Set;
+
+/**
+ * FilterOptions provides a method to select various filtering options for
doing a scan of the metrics database.
+ */
+public class FilterOptions {
+ private static final String componentId = "componentId";
+ private static final String topologyId = "topologyId";
+ private static final String startTime = "startTime";
+ private static final String endTime = "endTime";
+ private static final String metricName = "metricName";
+ private static final String executorId = "executorId";
+ private static final String hostId = "hostId";
+ private static final String port = "port";
+ private static final String streamId = "streamId";
+ private Map<String, Object> options = new HashMap<>();
--- End diff --
Any reason to store options into map with unnecessary explicit type
conversion instead of defining elements as fields?
---
