Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r173215187
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -392,6 +401,30 @@ public void establishLogSettingCallback() {
workerState.stormClusterState.topologyLogConfig(topologyId,
this::checkLogConfigChanged);
}
+ /**
+ * Send a heartbeat to local supervisor first to check if supervisor
is ok for heartbeating.
+ */
+ private void heartbeatToMasterIfLocalbeatFail(LSWorkerHeartbeat
lsWorkerHeartbeat) {
+ if (ConfigUtils.isLocalMode(this.conf)) {
--- End diff --
If you want to make this work in local mode we can do it. For nimbus we
have an override in NimbusClient so it will return the local nimbus instead.
We could do the same thing for a Supervisor with a specific port number too.
That would make local mode look and act a lot more like non-local mode. But it
is something we can do in a follow on JIRA.
---
