Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2433#discussion_r173213078
  
    --- Diff: 
storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java ---
    @@ -94,6 +108,8 @@
         @Deprecated
         List<String> backpressureTopologies();
     
    +    NimbusInfo getLeader(Runnable callback);
    --- End diff --
    
    I am a little weary of using this vs going directly to the leader elector.  
The issue really is one of fencing.  In some cases it is possible for the 
leader elector to lose leadership, but the other nodes in ZK to not be updated 
for a while.  I am fine with this API so long as we have the proper javadocs to 
explain that it cannot be used for fencing and is only for informational 
purposes.


---

Reply via email to