Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2433#discussion_r173219240
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
    @@ -319,14 +344,17 @@ private static StormBase make(TopologyStatus status) {
         private static final TopologyStateTransition REMOVE_TRANSITION = 
(args, nimbus, topoId, base) -> {
             LOG.info("Killing topology: {}", topoId);
             IStormClusterState state = nimbus.getStormClusterState();
    +        Assignment oldAss = state.assignmentInfo(topoId, null);
    --- End diff --
    
    Can we rename this variable.  It might be offensive to some people.


---

Reply via email to