Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2603#discussion_r176786400
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
    @@ -1754,7 +1762,7 @@ private TopologyResources 
getResourcesForTopology(String topoId, StormBase base)
                 try {
                     IStormClusterState state = stormClusterState;
                     TopologyDetails details = readTopologyDetails(topoId, 
base);
    -                Assignment assignment = state.assignmentInfo(topoId, null);
    +                Assignment assignment = getAssignmentInfo(state, topoId);
    --- End diff --
    
    We can just use `stormClusterState` directly without making another `state` 
variable. (Here and in the next method.)


---

Reply via email to