[GitHub] storm pull request #2603: [STORM-3003] Adding Assignment caching to Nimbus

[d2r]

Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2603#discussion_r176771823
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
    @@ -1196,6 +1198,12 @@ private IStormClusterState getStormClusterState() {
             return heartbeatsCache;
         }
     
    +    @VisibleForTesting
    +    public AtomicReference<Map<String, Assignment>> getAssignmentsCache() {
    +        return assignmentsCache;
    +    }
    +
    +
    --- End diff --
    
    * What uses this? Should we remove it?
       * In fact, same question for `getHeartbeatsCache`
    * nitpick: Else, can we remove the extra line here?


---