Github user hmcl commented on the issue:

    https://github.com/apache/storm/pull/2637
  
    @srishtyagrawal Thank you for the code review. It is much better now. 
Besides my two comments above, I still wonder if it would be better to point 
the links with the description of the Kafka properties to the top of the [New 
Consumer 
Configs](http://kafka.apache.org/10/documentation.html#newconsumerconfigs) 
table. The Javadocs have no description of the property and are basically the 
name of the property written using capital letters and underscores. This won't 
be very helpful to the user. It's better to be pointed to the table. The user 
will know then that he has to search for the name of the property there.


---

Reply via email to