Github user srishtyagrawal commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2637#discussion_r186570995
  
    --- Diff: docs/storm-kafka-client.md ---
    @@ -313,4 +313,39 @@ KafkaSpoutConfig<String, String> kafkaConf = 
KafkaSpoutConfig
       .setTupleTrackingEnforced(true)
     ```
     
    -Note: This setting has no effect with AT_LEAST_ONCE processing guarantee, 
where tuple tracking is required and therefore always enabled.
    \ No newline at end of file
    +Note: This setting has no effect with AT_LEAST_ONCE processing guarantee, 
where tuple tracking is required and therefore always enabled.
    +
    +# Translation from `storm-kafka` to `storm-kafka-client` spout properties
    +
    +This may not be an exhaustive list because the `storm-kafka` configs were 
taken from Storm 0.9.6
    
+[SpoutConfig](https://svn.apache.org/repos/asf/storm/site/releases/0.9.6/javadocs/storm/kafka/SpoutConfig.html)
 and
    
+[KafkaConfig](https://svn.apache.org/repos/asf/storm/site/releases/0.9.6/javadocs/storm/kafka/KafkaConfig.html).
    +`storm-kafka-client` spout configurations were taken from Storm 1.0.6
    
+[KafkaSpoutConfig](https://storm.apache.org/releases/1.0.6/javadocs/org/apache/storm/kafka/spout/KafkaSpoutConfig.html)
 
    +and Kafka 0.10.1.0 
[ConsumerConfig](https://kafka.apache.org/0101/javadoc/index.html?org/apache/kafka/clients/consumer/ConsumerConfig.html).
    +
    +| SpoutConfig   | KafkaSpoutConfig/ConsumerConfig Name | KafkaSpoutConfig 
Usage |
    --- End diff --
    
    Addressed.


---

Reply via email to