Github user priyank5485 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2665#discussion_r186560080
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/reporters/JmxStormReporter.java ---
@@ -67,7 +68,7 @@ public void prepare(MetricRegistry metricsRegistry,
Map<String, Object> stormCon
}
public static String getMetricsJMXDomain(Map reporterConf) {
- return Utils.getString(reporterConf, JMX_DOMAIN);
+ return
Utils.getString(reporterConf.get(Config.STORM_DAEMON_METRICS_REPORTER_PLUGIN_DOMAIN),
null);
--- End diff --
JMX_DOMAIN used initially is different than
Config.STORM_DAEMON_METRICS_REPORTER_PLUGIN_DOMAIN
I think we should stick to JMX_DOMAIN config key unless @ptgoetz thinks
this is good.
---
