Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2665#discussion_r186563440
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/reporters/JmxStormReporter.java ---
@@ -67,7 +68,7 @@ public void prepare(MetricRegistry metricsRegistry,
Map<String, Object> stormCon
}
public static String getMetricsJMXDomain(Map reporterConf) {
- return Utils.getString(reporterConf, JMX_DOMAIN);
+ return
Utils.getString(reporterConf.get(Config.STORM_DAEMON_METRICS_REPORTER_PLUGIN_DOMAIN),
null);
--- End diff --
I think user should be able to specify a domain so it cannot be a fixed
value like JMX_DOMAIN. So the proposed changes looks fine.
---
