Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2698#discussion_r192814411
  
    --- Diff: shaded-deps/pom.xml ---
    @@ -0,0 +1,272 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +  ~ Licensed to the Apache Software Foundation (ASF) under one
    +  ~ or more contributor license agreements.  See the NOTICE file
    +  ~ distributed with this work for additional information
    +  ~ regarding copyright ownership.  The ASF licenses this file
    +  ~ to you under the Apache License, Version 2.0 (the
    +  ~ "License"); you may not use this file except in compliance
    +  ~ with the License.  You may obtain a copy of the License at
    +  ~
    +  ~ http://www.apache.org/licenses/LICENSE-2.0
    +  ~
    +  ~ Unless required by applicable law or agreed to in writing, software
    +  ~ distributed under the License is distributed on an "AS IS" BASIS,
    +  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
    +  ~ See the License for the specific language governing permissions and
    +  ~ limitations under the License.
    +  -->
    +
    +<project xmlns="http://maven.apache.org/POM/4.0.0";
    +         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    +    <modelVersion>4.0.0</modelVersion>
    +
    +    <parent>
    +        <artifactId>storm</artifactId>
    +        <groupId>org.apache.storm</groupId>
    +        <version>2.0.0-SNAPSHOT</version>
    +        <relativePath>..</relativePath>
    +    </parent>
    +
    +    <groupId>org.apache.storm</groupId>
    +    <artifactId>shaded-deps</artifactId>
    +    <packaging>jar</packaging>
    +    <name>Shaded Deps for Storm Client</name>
    +    <description>Shaded version of dependencies used only for internal 
storm code.</description>
    +
    +    <dependencies>
    +        <dependency>
    +            <groupId>com.google.guava</groupId>
    +            <artifactId>guava</artifactId>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.apache.curator</groupId>
    +            <artifactId>curator-framework</artifactId>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.apache.curator</groupId>
    +            <artifactId>curator-client</artifactId>
    +        </dependency>
    +        <!-- recipes are not used by the client, but storm server uses the 
same
    --- End diff --
    
    Not sure I understand what this means. Is it saying that storm-server uses 
recipes, and that's why this dependency is here?


---

Reply via email to