Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193080453
--- Diff:
storm-client/src/jvm/org/apache/storm/container/cgroup/SystemOperation.java ---
@@ -54,8 +55,8 @@ public static String exec(String cmd) throws IOException {
Process process = new ProcessBuilder(new String[]{ "/bin/bash",
"-c", cmd }).start();
try {
process.waitFor();
- String output = IOUtils.toString(process.getInputStream());
- String errorOutput =
IOUtils.toString(process.getErrorStream());
+ String output = IOUtils.toString(process.getInputStream(),
Charsets.UTF_8);
--- End diff --
I can change it back if you want. I noticed that toString is deprecated if
you don't provide a character set, so I picked UTF_8 as that is the java
default. I agree that bash/posix can be configured to use different character
sets, but I thought UTF_8 was fairly standard now.
---
