GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2754
STORM-3133: Extend metrics on Nimbus and LogViewer
This PR is based on both #2743 and #2753 (merged) and implements the
following metrics:
LogViewer:
- [x] Time to complete one clean up loop Time. (timing on blocking calls)
- [x] Search request Cnt: By category - search (non-archived only) vs deep
search (archived/non-archived)
- [x] Search Request - Response time - search vs deep search (both timing
on blocking calls)
- [x] Search Request - 0 result Cnt - search vs deep search
- [x] Search Result - open files (scanned files, deep search only,
manually tested)
- [x] File Download request Cnt/ And Size served (round to MB)
Nimbus:
- [x] File upload time.
- [x] Nimbus launch/relaunch count
- [x] Nimbus loss of leadership
- [x] meter marking when a nimbus node gains or loses leadership
- [x] Excessive scheduling time (both duration distribution and current
longest)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zd-project/storm STORM-3133
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2754.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2754
----
commit 4ef024e0e4c67f2fb0cca4204d87c3526ed0e4d0
Author: Zhengdai Hu <hu.zhengdai@...>
Date: 2018-06-18T15:44:19Z
STORM-3030: Add Timer registration wrapper.
(cherry picked from commit 5338491)
commit 694e9109f532862cb1c3bd5a17a1264a9966c8d4
Author: Zhengdai Hu <hu.zhengdai@...>
Date: 2018-06-27T19:46:33Z
STORM-3130: Added object wrapper with timer in both decorator and
inheritance patterns.
commit fcd8ca9a44014e9f02d51d018285752baaf8d8b0
Author: Zhengdai Hu <hu.zhengdai@...>
Date: 2018-06-28T22:06:59Z
STORM-3130: Fixing various bugs in TimerDecorated wrappers
commit 42aeb46e2723e627a94d84ef1c030bf01ad0c4c3
Author: Zhengdai Hu <hu.zhengdai@...>
Date: 2018-06-29T16:32:20Z
STORM-3130: Trivial refactoring
commit 0cc4e0a1a84d029ec13dd37c15ad0ad922091c78
Author: Zhengdai Hu <zhengdai.hu@...>
Date: 2018-07-05T18:20:43Z
STORM-3133: Fixed bug of unnecessary inclusion of empty search result
commit b9f03bef42c8202578920e4221e33493af1d33e6
Author: Zhengdai Hu <zhengdai.hu@...>
Date: 2018-07-05T19:49:26Z
Merge branch 'STORM-3143' into STORM-3133
* STORM-3143:
STORM-3133: Fixed bug of unnecessary inclusion of empty search result
STORM-3142: Add JUnit 5 support, migrate a couple of tests in
storm-kafka-client to check that both JUnit 5 and 4 work. Also fix
storm-kafka-client tests so they delete their temporary directories when done
testing.
STORM-3137: Fix too strict mock verification in nimbus_test
STORM-3138: Have dev-zookeeper actually log to a file.
Abstract modules in travis script a bit
STORM-3061: Update commons libraries
STORM-3119: Build Storm with Java 10
Fixed permission issue when trying to launch example using flux
STORM-3061: mqtt-update
STORM-3061: Remove unneeded deps from rocketmq-examples
commit ded40885a02a4c04d18e2e968ca8bb6a672819cf
Author: Zhengdai Hu <zhengdai.hu@...>
Date: 2018-07-05T18:31:53Z
STORM-3133: Refactored and added metrics to LogViewer components
STORM-3133: Fixed up Unit test for LogViewer
commit 22457eb216eb32e05d91b5541a1e61e4f976f6b0
Author: Zhengdai Hu <hu.zhengdai@...>
Date: 2018-07-02T22:36:09Z
STORM-3133: Refactored and added metrics to Nimbus components.
----
---