[GitHub] storm pull request #2754: STORM-3133: Extend metrics on Nimbus and LogViewer

[Ethanlm]

Github user Ethanlm commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2754#discussion_r208689498
  
    --- Diff: 
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
 ---
    @@ -71,6 +78,11 @@
     
     public class LogviewerLogSearchHandler {
         private static final Logger LOG = 
LoggerFactory.getLogger(LogviewerLogSearchHandler.class);
    +    private static final Meter numDeepSearchNoResult = 
StormMetricsRegistry.registerMeter("logviewer:num-deep-search-no-result");
    +    private static final Histogram numFilesOpenedDeepSearch = 
StormMetricsRegistry.registerHistogram(
    +            "logviewer:num-files-opened-deep-search", new 
ExponentiallyDecayingReservoir());
    --- End diff --
    
    opened--> scanned? more clear


---