Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202632910
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/planner/streams/StreamsStormRuleSets.java
---
@@ -72,13 +72,13 @@
// merge and push unions rules
UnionEliminatorRule.INSTANCE,
- TridentScanRule.INSTANCE,
- TridentFilterRule.INSTANCE,
- TridentProjectRule.INSTANCE,
- TridentAggregateRule.INSTANCE,
- TridentJoinRule.INSTANCE,
- TridentModifyRule.INSTANCE,
- TridentCalcRule.INSTANCE
+ StreamsScanRule.INSTANCE,
+ StreamsFilterRule.INSTANCE,
+ StreamsProjectRule.INSTANCE,
+ StreamsAggregateRule.INSTANCE,
--- End diff --
This is to have control to warn to the end users when aggregate or join is
used in users' query. I didn't test if we don't have our own rule and user
query trigger the feature. Yeah it is also good to not forget about missing
features.
---
