[GitHub] storm pull request #2443: STORM-2406 [Storm SQL] Change underlying API to St...

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2443#discussion_r202650461
  
    --- Diff: 
sql/storm-sql-core/src/jvm/org/apache/storm/sql/planner/streams/StreamsStormRuleSets.java
 ---
    @@ -72,13 +72,13 @@
                 // merge and push unions rules
                 UnionEliminatorRule.INSTANCE,
     
    -            TridentScanRule.INSTANCE,
    -            TridentFilterRule.INSTANCE,
    -            TridentProjectRule.INSTANCE,
    -            TridentAggregateRule.INSTANCE,
    -            TridentJoinRule.INSTANCE,
    -            TridentModifyRule.INSTANCE,
    -            TridentCalcRule.INSTANCE
    +            StreamsScanRule.INSTANCE,
    +            StreamsFilterRule.INSTANCE,
    +            StreamsProjectRule.INSTANCE,
    +            StreamsAggregateRule.INSTANCE,
    --- End diff --
    
    Makes sense.


---