Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2789#discussion_r208014755
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -53,12 +55,14 @@ public static Meter registerMeter(String name) {
*
* @param topoConf config that specifies reporter plugin
*/
- public static void startMetricsReporters(Map<String, Object> topoConf)
{
- for (PreparableReporter reporter :
MetricsUtils.getPreparableReporters(topoConf)) {
+ public static AutoCloseable startMetricsReporters(Map<String, Object>
topoConf) {
--- End diff --
I'd probably just declare it in this file, we can always move it later if
we need to. If we make the registry non-static at some point, we probably won't
need it anymore, since we can just add a close method to the registry instead.
---
