Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2789#discussion_r208350201
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
    @@ -2807,7 +2808,14 @@ public void launchServer() throws Exception {
                                             }
                                         });
     
    -            StormMetricsRegistry.registerGauge("nimbus:num-supervisors", 
() -> state.supervisors(null).size());
    +            StormMetricsRegistry.registerGauge("nimbus:num-supervisors", 
() -> {
    +                try {
    +                    return state.supervisors(null).size();
    +                } catch (Exception e) {
    +                    e.printStackTrace();
    --- End diff --
    
    I don't think this is a reasonable fix, it's just hiding the error. 


---

Reply via email to