Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208746949
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2131,17 +2223,13 @@ private void mkAssignments(String scratchTopoId)
throws Exception {
}
}
// make the new assignments for topologies
- Map<String, SchedulerAssignment> newSchedulerAssignments = null;
synchronized (schedLock) {
- newSchedulerAssignments =
computeNewSchedulerAssignments(existingAssignments, topologies, bases,
scratchTopoId);
+ Map<String, SchedulerAssignment> newSchedulerAssignments =
+ computeNewSchedulerAssignments(existingAssignments,
topologies, bases, scratchTopoId);
+ //Should probably change List<Object> to Tuple<String, Long>
for better readability
--- End diff --
Again, probably better with another Jira for general code cleanup
---
