Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208699933
--- Diff: storm-client/src/jvm/org/apache/storm/scheduler/WorkerSlot.java
---
@@ -39,6 +42,11 @@ public String getId() {
return getNodeId() + ":" + getPort();
}
+ public List<Object> toList() {
+ //For compatibility to call in Nimbus#mkAssignment
--- End diff --
This seems to only be used in one place. Why is this better than invoking
`Arrays.asList(slot.getNodeId(), slot.getPort())`?
The reason I'm asking is that to me, there isn't an obvious WorkerSlot to
List translation, so I think a generic toList like this decreases readability
compared to just writing out this code in Nimbus.
Same comment for ExecutorDetails.
---
