Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209095662
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -253,12 +276,11 @@ private long lastModifiedTimeWorkerLogdir(File
logDir) {
return curr > maximum ? curr : maximum;
}, BinaryOperator.maxBy(Long::compareTo));
} catch (Exception ex) {
+ //This is not IOException
--- End diff --
Okay. This is actually one of my concern, that the metrics for exceptions
counting may be easily outdated. I'm wondering if there's a way to break the
code after intentionally to remind people to update metrics?
---
