Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209092525
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of Logviewer.
*/
-public class LogviewerServer implements AutoCloseable {
+public class LogviewerServer implements AutoCloseable, MetricSet {
--- End diff --
Just to be clear, I'm talking about removing `implements MetricSet` from
LogviewerServer and replacing it with
`StormMetricsRegistry.registerMetricSet(ExceptionMeters::getMetrics);`.
ExceptionMeters doesn't need to implement MetricSet.
---
