Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209306763
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler() {
}
+ //enum NotPorted {
+ // //Declared in StormConf. I don't see the value in reporting so.
+ // SUPERVISOR_TOTAL_RESOURCE,
+ // //May be able to aggregate based on status;
+ // TOPOLOGY_STATUS,
+ // TOPOLOGY_SCHED_STATUS,
+ // //May be aggregated, as well as other distinct values
+ // NUM_DISTINCT_NIMBUS_VERSION;
+ //}
+
+ private class ClusterSummaryMetricSet implements MetricSet, Runnable {
--- End diff --
That can be solved by making `getClusterInfoImpl` package private, but I
see your point. Maybe we just leave it here for now, and I'll see if we can do
something with it when I look at the non-static registry branch. It's not like
it hurts anything to have it here, I'd just rather have it in another file if
possible.
---
