Github user zd-project commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2764#discussion_r209335050
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
    @@ -2905,6 +2929,10 @@ public void launchServer() throws Exception {
                                                 throw new RuntimeException(e);
                                             }
                                         });
    +
    +            //Should we make the delaySecs and recurSecs in sync with any 
conf value?
    --- End diff --
    
    I would very much love to. However based on current Nimbus implementation 
there's no way to do it. There's is however one leadership change callback 
buried in Zookeeper side code (See `LeaderListenerCallback`), which 
communicates through IStormClusterState. It'll be great if you can open a PR to 
improve Nimbus in general, along with 
[STORM-3187](https://issues.apache.org/jira/browse/STORM-3187). Otherwise we 
kind of have to using busy waiting here. 


---

Reply via email to