Derek, I am OK with closing them all. By phase I meant perhaps leaving some of the most recent one's in case the author wants to resume them... but I guess he can always reopen them. Stig, the JIRAs I think the should be handled on an individual basis. If they are still revenant, leave the JIRA open hoping someone will pick it up. If they are no longer relevant, perhaps close as "will not fix" or something like that.
Hugo On Wed, Oct 10, 2018 at 11:12 AM Stig Rohde Døssing <[email protected]> wrote: > +1 to close old PRs. > > What is the value in keeping the associated Jira issues around though? > > Den tir. 9. okt. 2018 kl. 17.18 skrev Derek Dagit <[email protected] > >: > > > > Is the idea to remove them all in one batch, or have the removal > process > > through phases ? > > > > Yeah, the idea was to close them all in one batch. We do not want to > close > > pull requests that have value, and we want to balance this with the > effort > > required to review each one to see if it instead should be kept open. > > > > If we are interested in putting in more effort, then we could remove in > > phases. > > > > On Mon, Oct 8, 2018 at 5:30 PM Hugo Louro <[email protected]> wrote: > > > > > +1 to remove old PRs. If any PRs still warrant any value we could try > > > reaching out to the creator to see if he wants to follow up with it. Is > > the > > > idea to remove them all in one batch, or have the removal process > through > > > phases ? > > > > > > On Mon, Oct 8, 2018 at 3:26 PM Jungtaek Lim <[email protected]> wrote: > > > > > > > +1 It doesn't look like there're any critical PRs in the list, and it > > is > > > > pretty less chance we could connect with PR authors. > > > > > > > > -Jungtaek Lim (HeartSaVioR) > > > > > > > > 2018년 10월 9일 (화) 오전 5:08, Kishorkumar Patil <[email protected] > > >님이 > > > > 작성: > > > > > > > > > +1. > > > > > It would be nice to clean up old clutter while we are getting ready > > for > > > > > days past 2.x > > > > > > > > > > -Kishor > > > > > > > > > > > > > > > On Mon, Oct 8, 2018 at 3:52 PM Bobby Evans <[email protected]> > wrote: > > > > > > > > > > > +1 > > > > > > > > > > > > Sounds good to me > > > > > > > > > > > > On Mon, Oct 8, 2018 at 2:50 PM Derek Dagit > <[email protected] > > > > > > > > > wrote: > > > > > > > > > > > > > Currently there are over 150 open pull requests on the Apache > > Storm > > > > > > GitHub > > > > > > > project. Over 100 of these have not been modified in 2018. > > > > > > > > > > > > > > It seems we are unlikely to handle each one of these without > > > > > significant > > > > > > > effort and time. Looking at many of them, they seem to be > > abandoned > > > > by > > > > > > the > > > > > > > requester. > > > > > > > > > > > > > > I propose in STORM-3250 that we close all pull requests that > have > > > not > > > > > > been > > > > > > > updated in 2018 and leave any corresponding Jira issues as they > > > are. > > > > If > > > > > > > there are any pull requests among these should remain open, > > please > > > > let > > > > > me > > > > > > > know. I plan to wait at least a week before requesting any > > changes. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/storm/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+updated%3A%3C2018-01-01 > > > > > > > > > > > > > > -- > > > > > > > Derek > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > Derek > > >
