Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r228303554
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java ---
@@ -87,7 +87,7 @@ public Slot(AsyncLocalizer localizer, Map<String, Object>
conf,
AtomicReference<Map<Long, LocalAssignment>>
cachedCurrentAssignments,
OnlyLatestExecutor<Integer> metricsExec,
WorkerMetricsProcessor metricsProcessor,
- SlotMetrics slotMetrics) throws Exception {
+ SlotMetrics slotMetrics, String numaId) throws Exception {
--- End diff --
Can we remove this? It looks like it's not used anywhere
---
