Github user govind-menon commented on a diff in the pull request:
https://github.com/apache/storm/pull/2881#discussion_r229854058
--- Diff:
storm-server/src/test/java/org/apache/storm/daemon/supervisor/BasicContainerTest.java
---
@@ -319,7 +319,15 @@ public void testLaunch() throws Exception {
superConf.put(Config.STORM_WORKERS_ARTIFACTS_DIR, stormLocal);
superConf.put(DaemonConfig.STORM_LOG4J2_CONF_DIR, log4jdir);
superConf.put(Config.WORKER_CHILDOPTS, " -Dtesting=true");
-
+ Map numaNode = new HashMap();
+ numaNode.put(Utils.NUMA_ID, "0");
+ numaNode.put(Utils.NUMA_CORES, Collections.singletonList("0"));
+ numaNode.put(Utils.NUMAS_PORTS, Collections.singletonList(8081));
+ numaNode.put(Utils.NUMA_MEMORY_IN_MB, 2048);
+ Map numaMap = new HashMap();
+ numaMap.put(Utils.NUMAS_BASE, Collections.singletonList(numaNode));
+
+ superConf.put(Config.SUPERVISOR_NUMA_META, numaMap);
--- End diff --
No i explicitly want this so that we show that there is no numa pinning
when there is no config.
---
