bipinprasad commented on a change in pull request #3213: [STORM-3588] add
GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource
in grading topologies
URL: https://github.com/apache/storm/pull/3213#discussion_r394781127
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java
##########
@@ -56,6 +59,10 @@
private int schedulingTimeoutSeconds;
private ExecutorService backgroundScheduling;
+ // record evicted topologies on each scheduling round, only used in test
purpose now
+ private boolean forTest = false;
+ private Set<String> evictedTopologies = new HashSet<>();
+
Review comment:
Can this be removed. Use
TestUtilsForResourceAwareScheduler#assertTopologiesNotScheduled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
