Ethanlm commented on a change in pull request #3213: [STORM-3588] add
GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource
in grading topologies
URL: https://github.com/apache/storm/pull/3213#discussion_r404830638
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java
##########
@@ -113,6 +119,9 @@ public void schedule(Topologies topologies, Cluster
cluster) {
} else {
User submitter = userMap.get(td.getTopologySubmitter());
scheduleTopology(td, cluster, submitter, orderedTopologies);
+ if (!evictedTopologies.isEmpty()) {
+ LOG.warn("Evicted Topologies {} when scheduling topology:
{}", evictedTopologies, td.getId());
Review comment:
evictedTopologies is cumulated during scheduling all the topologies since it
only clears `evictedTopologies` at Line 111. So `evictedTopologies` here
include all the evictedTopologies not only evicted by scheduling this topology
`td.getId()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
