Ethanlm commented on a change in pull request #3213: [STORM-3588] add
GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource
in grading topologies
URL: https://github.com/apache/storm/pull/3213#discussion_r406831958
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java
##########
@@ -248,6 +255,11 @@ private void scheduleTopology(TopologyDetails td, Cluster
cluster, final User to
+
topologySchedulingResources.getRemainingRequiredResourcesMessage());
}
+ public Map<String, Set<String>> getEvictedTopologiesMap() {
Review comment:
I would add a comment like `This method is not stable. It's subject to
change` since we don't really use it elsewhere besides unit test currently. It
might change depending on how we want to use the evictedTopologies information.
As @bipinprasad said, we might want to put it into the scheduleResult in the
future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
