bipinprasad commented on a change in pull request #3213: [STORM-3588] add 
GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource 
in grading topologies
URL: https://github.com/apache/storm/pull/3213#discussion_r405438903
 
 

 ##########
 File path: 
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java
 ##########
 @@ -239,6 +246,10 @@ private void scheduleTopology(TopologyDetails td, Cluster 
cluster, final User to
         markFailedTopology(topologySubmitter, cluster, td, "Failed to schedule 
within " + maxSchedulingAttempts + " attempts");
     }
 
+    public Set<String> getEvictedTopologies() {
 
 Review comment:
   As a member of SchedulingResult this information can be more useful.
   But looks like the intent is to keep track of topologies evicted as part of 
each topo scheduled, in which case we need a map i.e. topoId -> toposEvicted

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to