RuiLi8080 commented on a change in pull request #3213: [STORM-3588] add
GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource
in grading topologies
URL: https://github.com/apache/storm/pull/3213#discussion_r406945579
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java
##########
@@ -57,6 +59,8 @@
private int maxSchedulingAttempts;
private int schedulingTimeoutSeconds;
private ExecutorService backgroundScheduling;
+ private Map<String, Set<String>> evictedTopologiesMap = new HashMap<>();
// topoId : topoEvicted
+ private Map<String, Set<String>> tmpEvictedTopologiesMap = new HashMap<>();
Review comment:
I was thinking not to add more parameters to he private scheduleTopology
function, but I think this makes sense and fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
