RuiLi8080 commented on a change in pull request #3213: [STORM-3588] add
GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource
in grading topologies
URL: https://github.com/apache/storm/pull/3213#discussion_r407854045
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/ISchedulingState.java
##########
@@ -271,6 +273,13 @@ boolean wouldFit(
*/
double getClusterTotalMemoryResource();
+ /**
+ * Get the total amount of generic resources (excluding CPU and memory) in
cluster.
+ */
+ default Map<String, Double> getClusterTotalGenericResources() {
+ return Collections.emptyMap();
Review comment:
No we don't. Only cluster class implement this interface and cluster will
have the implementation in this PR. Good catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
