bipinprasad commented on a change in pull request #3284:
URL: https://github.com/apache/storm/pull/3284#discussion_r437628463
##########
File path:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java
##########
@@ -130,14 +130,15 @@ public BasicContainer(ContainerType type, Map<String,
Object> conf, String super
super(type, conf, supervisorId, supervisorPort, port, assignment,
resourceIsolationManager, workerId, topoConf, ops,
metricsRegistry, containerMemoryTracker);
assert (localState != null);
+ assert (resourceIsolationManager != null);
Review comment:
instead of assert (which will not be active at runtime), do we want to
raise an IllegalArgumentException here? If resourceIsolationManager is null,
then there will be NPE anyway elsewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
