Ethanlm commented on a change in pull request #3284:
URL: https://github.com/apache/storm/pull/3284#discussion_r437644410
##########
File path:
storm-server/src/main/java/org/apache/storm/container/cgroup/CgroupManager.java
##########
@@ -305,8 +302,7 @@ private void prefixNumaPinning(List<String> command, String
numaId) {
return newCommand;
}
- @Override
- public Set<Long> getRunningPids(String workerId) throws IOException {
+ private Set<Long> getRunningPids(String workerId) throws IOException {
Review comment:
There might be different ways of killing processes for a worker,
depending on the implementation, docker, runc. So this method is not general
enough to be placed in the interface
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
