bipinprasad commented on a change in pull request #3283:
URL: https://github.com/apache/storm/pull/3283#discussion_r437702240
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/TopologyDetails.java
##########
@@ -193,22 +200,44 @@ private void initResourceList() {
}
/**
- * Returns a representation of the non-system components of the topology
graph Each Component object in the returning map is populated
+ * Returns a representation of the non-system components of the topology
graph. Each Component object in the returning map is populated
* with the list of its parents, children and execs assigned to that
component.
*
* @return a map of components
*/
- public Map<String, Component> getComponents() {
+ public Map<String, Component> getTopoComponents() {
+ if (topologyComponentsMap == null) {
Review comment:
TopologyDetails gets instantiated a large number of times. It was my
observation that adding members or such cacheing in TopologyDetails was
counterproductive. topologyComponentsMap and its sister cache allComponentsMap
should not be added unless we actually gain from cacheing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
