bipinprasad commented on a change in pull request #3283:
URL: https://github.com/apache/storm/pull/3283#discussion_r437712750
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java
##########
@@ -539,30 +541,34 @@ protected String nodeToRack(RasNode node) {
* @return a list of executors in sorted order
*/
private List<ExecutorDetails> orderExecutorsDefault(
Review comment:
It will be convenient if the even-distribution executor re-sorting was a
single method that could be applied to executor list.
This way the upcoming refactoring of the scheduling strategies would be
easier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
