Ethanlm commented on a change in pull request #3294:
URL: https://github.com/apache/storm/pull/3294#discussion_r445751740
##########
File path: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
##########
@@ -196,6 +198,8 @@ private Object loadWorker(IStateStorage stateStorage,
IStormClusterState stormCl
throws Exception {
workerState = new WorkerState(conf, context, topologyId, assignmentId,
supervisorIfaceSupplier, port, workerId,
topologyConf, stateStorage,
stormClusterState, autoCreds, metricRegistry);
+ this.heatbeatMeter = metricRegistry.meter("doHeartbeat-calls",
workerState.getWorkerTopologyContext(),
+ "__system", -1, "default");
Review comment:
I see there is already a metricName function
https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java#L244
which doesn't take streamId
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
