Ethanlm commented on a change in pull request #3294:
URL: https://github.com/apache/storm/pull/3294#discussion_r445752673
##########
File path: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
##########
@@ -196,6 +198,8 @@ private Object loadWorker(IStateStorage stateStorage,
IStormClusterState stormCl
throws Exception {
workerState = new WorkerState(conf, context, topologyId, assignmentId,
supervisorIfaceSupplier, port, workerId,
topologyConf, stateStorage,
stormClusterState, autoCreds, metricRegistry);
+ this.heatbeatMeter = metricRegistry.meter("doHeartbeat-calls",
workerState.getWorkerTopologyContext(),
+ "__system", -1, "default");
Review comment:
Also I feel like the metrics should have the key before the value, for
example, we now have
`xx.<compId>.<taskId>.yy`.
I think it should be `xx.componentId.<compId>.taskId.<taskId>.yy` so the
values are more readable. But this is a separate issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
