kishorvpatil commented on a change in pull request #3295:
URL: https://github.com/apache/storm/pull/3295#discussion_r446379664
##########
File path: storm-client/src/jvm/org/apache/storm/executor/ExecutorShutdown.java
##########
@@ -60,16 +60,7 @@ public ExecutorStats renderStats() {
@Override
public void credentialsChanged(Credentials credentials) {
- TupleImpl tuple = new TupleImpl(executor.getWorkerTopologyContext(),
new Values(credentials),
- Constants.SYSTEM_COMPONENT_ID, (int)
Constants.SYSTEM_TASK_ID,
-
Constants.CREDENTIALS_CHANGED_STREAM_ID);
- AddressedTuple addressedTuple = new
AddressedTuple(AddressedTuple.BROADCAST_DEST, tuple);
- try {
- executor.getReceiveQueue().publish(addressedTuple);
- executor.getReceiveQueue().flush();
- } catch (InterruptedException e) {
- throw new RuntimeException(e);
- }
+ executor.needToRefreshCreds = true;
Review comment:
Since the _SpoutExecutor_ and _BoltExecutor_ during init uses the
initialCredentials, the _accept_ method does not need to worry about it.
##########
File path: storm-client/src/jvm/org/apache/storm/executor/ExecutorShutdown.java
##########
@@ -60,16 +60,7 @@ public ExecutorStats renderStats() {
@Override
public void credentialsChanged(Credentials credentials) {
- TupleImpl tuple = new TupleImpl(executor.getWorkerTopologyContext(),
new Values(credentials),
- Constants.SYSTEM_COMPONENT_ID, (int)
Constants.SYSTEM_TASK_ID,
-
Constants.CREDENTIALS_CHANGED_STREAM_ID);
- AddressedTuple addressedTuple = new
AddressedTuple(AddressedTuple.BROADCAST_DEST, tuple);
- try {
- executor.getReceiveQueue().publish(addressedTuple);
- executor.getReceiveQueue().flush();
- } catch (InterruptedException e) {
- throw new RuntimeException(e);
- }
+ executor.needToRefreshCreds = true;
Review comment:
e.g.
https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/executor/spout/SpoutExecutor.java#L144-L146
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
