kishorvpatil commented on a change in pull request #3295:
URL: https://github.com/apache/storm/pull/3295#discussion_r448381948
##########
File path: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
##########
@@ -415,13 +414,13 @@ public void updateBlobUpdates() throws IOException {
public void checkCredentialsChanged() {
Credentials newCreds =
workerState.stormClusterState.credentials(topologyId, null);
- if (!ObjectUtils.equals(newCreds, credentialsAtom.get())) {
+ if (!ObjectUtils.equals(newCreds,
this.workerState.credentialsAtom.get())) {
// This does not have to be atomic, worst case we update when one
is not needed
ClientAuthUtils.updateSubject(subject, autoCreds, (null ==
newCreds) ? null : newCreds.get_creds());
for (IRunningExecutor executor : executorsAtom.get()) {
executor.credentialsChanged(newCreds);
}
- credentialsAtom.set(newCreds);
+ this.workerState.credentialsAtom.set(newCreds);
Review comment:
Moved this up before for loop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
