Ethanlm commented on a change in pull request #3318:
URL: https://github.com/apache/storm/pull/3318#discussion_r465125683
##########
File path:
storm-server/src/main/java/org/apache/storm/daemon/metrics/MetricsUtils.java
##########
@@ -58,10 +61,11 @@ private static PreparableReporter
getPreparableReporter(String clazz) {
return reporter;
}
- public static File getCsvLogDir(Map<String, Object> topoConf) {
- String csvMetricsLogDirectory =
ObjectReader.getString(topoConf.get(DaemonConfig.STORM_DAEMON_METRICS_REPORTER_CSV_LOG_DIR),
null);
+ public static File getCsvLogDir(Map<String, Object> daemonConf) {
Review comment:
Yeah, but for compatibility, I can't simply move it. If any topology
invokes it directly, and if we move it and upgrade the cluster, this old
topology will has ClassNotFoundException.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
