Ethanlm commented on a change in pull request #3318:
URL: https://github.com/apache/storm/pull/3318#discussion_r465276884
##########
File path: storm-client/src/jvm/org/apache/storm/Config.java
##########
@@ -1731,21 +1744,28 @@
@IsInteger
@IsPositiveNumber
public static final String WORKER_BLOB_UPDATE_POLL_INTERVAL_SECS =
"worker.blob.update.poll.interval.secs";
+
/**
- * A specify Locale for daemon metrics reporter plugin. Use the specified
IETF BCP 47 language tag string for a Locale.
+ * Specify the Locale for daemon metrics reporter plugin. Use the
specified IETF BCP 47 language tag string for a Locale.
+ * This config should have been placed in the DaemonConfig class. Keeping
it here only for backwards compatibility.
*/
@IsString
public static final String STORM_DAEMON_METRICS_REPORTER_PLUGIN_LOCALE =
"storm.daemon.metrics.reporter.plugin.locale";
+
/**
- * A specify rate-unit in TimeUnit to specify reporting frequency for
daemon metrics reporter plugin.
+ * Specify the rate unit in TimeUnit for daemon metrics reporter plugin.
+ * This config should have been placed in the DaemonConfig class. Keeping
it here only for backwards compatibility.
*/
@IsString
public static final String STORM_DAEMON_METRICS_REPORTER_PLUGIN_RATE_UNIT
= "storm.daemon.metrics.reporter.plugin.rate.unit";
+
/**
- * A specify duration-unit in TimeUnit to specify reporting window for
daemon metrics reporter plugin.
+ * Specify the duration unit in TimeUnit for daemon metrics reporter
plugin.
+ * This config should have been placed in the DaemonConfig class. Keeping
it here only for backwards compatibility.
Review comment:
I reverted the change because nimbus_test.clj is complaining.
```
Caused by: java.lang.IllegalStateException:
STORM-DAEMON-METRICS-REPORTER-PLUGIN-DURATION-UNIT already refers to:
#'org.apache.storm.daemon-config/STORM-DAEMON-METRICS-REPORTER-PLUGIN-DURATION-UNIT
in namespace: org.apache.storm.nimbus-test
```
Will file a JIRA to deal with that once this PR is merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
