Ethanlm commented on a change in pull request #3306:
URL: https://github.com/apache/storm/pull/3306#discussion_r467682217
##########
File path: storm-core/src/jvm/org/apache/storm/command/GetErrors.java
##########
@@ -42,15 +42,10 @@ public static void main(String[] args) throws Exception {
public void run(Nimbus.Iface client) throws Exception {
GetInfoOptions opts = new GetInfoOptions();
opts.set_num_err_choice(NumErrorsChoice.ONE);
- String topologyId = Utils.getTopologyId(name, client);
-
- TopologyInfo topologyInfo = null;
- if (topologyId != null) {
- topologyInfo = client.getTopologyInfoWithOpts(topologyId,
opts);
- }
+ TopologyInfo topologyInfo =
client.getTopologyInfoByNameWithOpts(name, opts);
Map<String, Object> outputMap = new HashMap<>();
- if (topologyId == null || topologyInfo == null) {
+ if (topologyInfo == null) {
Review comment:
> Will topologyInfo ever be `null`?
With the implementation in this PR, `getTopologyInfoByNameWithOpts` will
throw an `WrappedNotAliveException` (an TException) if the topology is not
alive. So the result will never be null. We need a different check here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
